On 29/09/2018 21:59, Lance Andersen wrote:
Attached is the webrev for the JDBC RowSet/DriverManager issue, 
https://bugs.openjdk.java.net/browse/JDK-8211295 
<https://bugs.openjdk.java.net/browse/JDK-8211295>,  that was raised on the 
thread: 
http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-September/055755.html

I have run the JDBC TestSuite against the Derby Embedded and Derby Network 
server;  Mach 5 jdk tier1, tier2, and tier3 tests as well as the JCK java.sql 
and javax.sql tests.  All pass with the fix

The webrev can be found at http://cr.openjdk.java.net/~lancea/8211295/webrev.00/ 
<http://cr.openjdk.java.net/~lancea/8211295/webrev.00/>

This looks okay, I just wonder if there are any other factory or other methods that should be exercised in the test to ensure that we have all code paths that lead to DriverManager.

-Alan

Reply via email to