Thanks Joe for the reminder, and thanks all for doing this! The change
looks good to me as well. I assume you updated copyright locally, not
reflected in the webrev. With regards to the class documentation, it's
confusing probably due to a class refactoring during the development.
That part of the history was gone. But we know what's going on, so we
can leave it as is since it's in maintenance.
Best,
Joe
On 10/15/18, 11:20 AM, Joseph D. Darcy wrote:
I think it would be reasonable to give engineers who work in the XML
area some time to review the fix as well before it is pushed.
Cheers,
-Joe
On 10/15/2018 11:13 AM, Aleksey Shipilev wrote:
On 10/15/2018 07:50 PM, Kim Barrett wrote:
Fix:
http://cr.openjdk.java.net/~shade/8212178/webrev.01/
Change looks good. Update copyright?
Thanks! Updated. jdk-submit is clean, I am going to push it soon.
The class documentation here seems very confusing to me, like it’s
not really about
this class at all. But that’s an entirely different problem.
Right.
-Aleksey
