+1 > On Oct 17, 2018, at 4:50 PM, Andrew Luo <[email protected]> > wrote: > > Done as well, thanks for spotting that also. > > diff --git a/src/java.base/share/classes/java/lang/ref/Cleaner.java > b/src/java.base/share/classes/java/lang/ref/Cleaner.java > --- a/src/java.base/share/classes/java/lang/ref/Cleaner.java > +++ b/src/java.base/share/classes/java/lang/ref/Cleaner.java > @@ -100,8 +100,8 @@ > * } > * } > * > - * private final State; > - * private final Cleaner.Cleanable cleanable > + * private final State state; > + * private final Cleaner.Cleanable cleanable; > * > * public CleaningExample() { > * this.state = new State(...); > > Thanks, > > -Andrew > > From: Lance Andersen <[email protected] > <mailto:[email protected]>> > Sent: Wednesday, October 17, 2018 11:33 AM > To: Andrew Luo <[email protected] > <mailto:[email protected]>> > Cc: [email protected] <mailto:[email protected]> > Subject: Re: [PATCH] Fix typo in javadoc for java.lang.ref.Cleaner > > Change seems to make sense > > looks like a semi-colon could be added after as well as part of the update: > > private final Cleaner.Cleanable cleanable > > > > On Oct 17, 2018, at 2:10 PM, Andrew Luo <[email protected] > <mailto:[email protected]>> wrote: > > Noticed a typo in the Javadoc for Cleaner... Patch attached below: > > diff --git a/src/java.base/share/classes/java/lang/ref/Cleaner.java > b/src/java.base/share/classes/java/lang/ref/Cleaner.java > --- a/src/java.base/share/classes/java/lang/ref/Cleaner.java > +++ b/src/java.base/share/classes/java/lang/ref/Cleaner.java > @@ -100,7 +100,7 @@ > * } > * } > * > - * private final State; > + * private final State state; > * private final Cleaner.Cleanable cleanable > * > * public CleaningExample() { > > Thanks, > > Andrew > > <image001.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> > > <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| > Principal Member of Technical Staff | +1.781.442.2037 > Oracle Java Engineering > 1 Network Drive > Burlington, MA 01803 > [email protected] <mailto:[email protected]> > > > >
<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 [email protected] <mailto:[email protected]>
