Hi Naoto,

I'd like to see a bit some discussion up front about the expected evolution of this class.

For example, "once an era is defined, subsequent versions of the API will add a constant for it. etc. Eras are expected to have consecutive integers associated with them, etc. "

Once a formal name is added for the new era, will that value be serial equivalent to the current new era value being used in the class? Basically, is the name or the int value the basis of the serial identity of a JapaneseEra object?

Thanks,

-Joe


On 10/26/2018 2:00 PM, naoto.s...@oracle.com wrote:
Hello,

Please review the fix to the following issue:

https://bugs.openjdk.java.net/browse/JDK-8212941

The proposed fix and CSR (not approved yet) are located at:

http://cr.openjdk.java.net/~naoto/8212941/webrev.02/
https://bugs.openjdk.java.net/browse/JDK-8212942

This change is intended to loosen the spec of JapaneseEra so that later era additions won't require unnecessary spec changes. This is particularly important for the maintenance releases.

Naoto

Reply via email to