Hi Coleen,

yes, the changes to the jvm.h functions should have a CSR.
I created a CSR to track the interface change.

  https://bugs.openjdk.java.net/browse/JDK-8213895

Thanks, Roger


On 11/14/2018 11:22 AM, coleen.phillim...@oracle.com wrote:

Hi Roger, the VM changes to this look great to me.

I think you need a CSR to remove JVM_InitProperties though.

Thanks,
Coleen

On 11/13/18 10:59 AM, Roger Riggs wrote:
Please review a re-implementation of the initialization of System properties
moving some functions from native to Java.

The upcalls from native to java for each property are replaced by a mechanism
to gather the platform, VM and command line properties and return them
from a single JNI call.  The creation of the Properties instance and applying
command line overrides is handled in Java instead of native.

The JVM_initProperties interface in Hotspot is replaced by JVM_getProperties.

Webrev:
  http://cr.openjdk.java.net/~rriggs/webrev-props-only-raw/

Issue:
  https://bugs.openjdk.java.net/browse/JDK-4947890

Thanks, Roger



Reply via email to