> Can you fix the stat usages in TimeZonone_md.c too? Hi Alan,
I've done this here: http://cr.openjdk.java.net/~njian/8214077/webrev.2/ I'm a bit unsure about #ifndef MACOSX - some existing files guard the stat64 #define with this (e.g. UnixFileSystem_md.c) and some don't (e.g. libnio/ch/FileDispatcherImpl.c). I don't have access to an OS X machine to test, but I guess it doesn't matter too much as AFAIK Apple haven't supported 32-bit for a long time? Thanks, Nick > -----Original Message----- > From: Alan Bateman <alan.bate...@oracle.com> > Sent: 22 November 2018 19:05 > To: Nick Gasson <nick.gas...@arm.com>; Magnus Ihse Bursie > <magnus.ihse.bur...@oracle.com>; build-dev <build-...@openjdk.java.net>; > core-libs-dev@openjdk.java.net > Cc: nd <n...@arm.com> > Subject: Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on > ARM32 > > > > On 22/11/2018 10:54, Nick Gasson wrote: > >>>> Have you looked at replacing the remaining usages of stat changed to > >>>> stat64 instead? > >>> I've tried this just now and it also resolves the issue. I can > >>> test on some more platforms and update the webrev if this is the > >>> preferred solution? > >> I'd say this is preferred to adding compiler flags, yes. The code will > >> make it unambiguously clear that it's correct. > > Here is the updated webrev that uses stat64: > > > > http://cr.openjdk.java.net/~njian/8214077/webrev.1/ > > > Can you fix the stat usages in TimeZonone_md.c too? > > -Alan
