Thanks for the review, Alan and Magnus. Cheers, Henry
> On Nov 30, 2018, at 7:20 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > > > On 28/11/2018 22:49, Henry Jen wrote: >> Since there is no header file in JDK provides the function prototypes, I >> don’t think this is considered public(supported) APIs. >> >> Anyway, in case a tools is build with launcher code, and shipped separately >> from JDK, that would be impacted by this bug. So I added a test call >> JLI_Launch as well. Please review the updated webrev[1]. >> >> Note that, JLI_Launch should not be used directly as it does’t handle the >> argument processing which is done in launcher/main.c. >> >> Cheers, >> Henry >> >> [1] http://cr.openjdk.java.net/~henryjen/jdk12/8213362.1/webrev/ >> > Updated webrev looks okay. I do find the exeXXX convention for the launchers > created in the test make files very strange but this is something we can > chase up with another issue. > > -Alan
