On 10/12/2018 11:01, Magnus Ihse Bursie wrote:
On 2018-12-07 21:20, Roger Riggs wrote:
Hi,
It is a nice feature that charsets are selected at build time using
the stdcs-xxx files.
This change breaks that pattern and embeds os specific information in
more than one place.
That does not seem like an improvement. Is there any alternative?
I agree. Why is it not enough just to add it to stdcs-aix?
My reading of the patch is that the "os" key is to avoid generating it
on non-AIX platforms, it will otherwise end up in jdk.charsets on
non-AIX platforms. The general direction is welcome but I think further
work and discussion will be needed to get the right set of changes to
support filtering in the build. It can probably be separated from the
changes to add IBM-29626C to AIX's java.base.
-Alan
