Hi Philipp,
I'm satisfied with this update.
BTW, your workspace may be a bit out of date, the patch did not merge
without warnings.
For convenience of other reviewers, here a webrev:
http://cr.openjdk.java.net/~rriggs/webrev-8066619-3.patch/
Thanks, Roger
On 12/18/2018 02:15 AM, Philipp Kunz wrote:
Thanks. Find a new patch attached.
On Mon, 2018-12-17 at 12:12 -0500, Roger Riggs wrote:
Hi Philipp,
Manifest.java:
- Line 258: creating a new array for two characters on each call
isn't as efficient as:
out.write('\r');
out.write('\n').
The new test that need internal access can gain that access by adding:
@modules java.base/java.util.jar:+open
That instructs testng to add the correct command line switches.
Then you can remove --illegal-access=warn and the tests will work.
In the test ValueUtf8Coding, just a mention of a method to create a
string with repeats.
"-".repeat(80);
