Hi Christoph > On Jan 15, 2019, at 3:10 AM, Langer, Christoph <christoph.lan...@sap.com> > wrote: > > Hi Lance, > >> Thank you for the feedback, please see below > Welcome, thanks for addressing my findings 😊 > >> line 97: spelling: “filter” >> fixed though was “DirectoryStream.Filter” which I changed to >> DirectoryStream filter > > Hm, not quite yet... What I mean is still in line 96: > * Iterator correctly indicates whether the filer has been matched > -> I think you mean filter instead of filer here. >
OK fixed >> line 309: you could use an import java.util.zip.ZipException? >> done, still getting used to Intellij vs Netbeans which I like better for >> import >> handling > I'm currently using Eclipse though I should try IntelliJ, too. As for > imports, I would also think the org.testng.* imports should go after the > java.* imports. But not sure if there's some official style guide for that. Well the ordering was done via Intellij so I am going to leave that for now. > > Overall, looks good to me now. (The latest webrev, that addresses Alan's > point, too) Thank you. Best Lance > > Best regards > Christoph > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
