Hi Joe I think this is fine. I might consider beefing up the test assertEquals message it is just the name
Assert.assertEquals(value, prValues[i], prNames[i]); HTH Best Lance > On Mar 11, 2019, at 2:22 PM, Joe Wang <huizhe.w...@oracle.com> wrote: > > Please review a fix for a JCK failure. All XML-related JCK and SQE tests > passed after the patch. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8219705 > webrevs: http://cr.openjdk.java.net/~joehw/jdk13/8219705/webrev/ > > Thanks, > Joe > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
