Hi Daniel, > On Mar 13, 2019, at 3:05 PM, Daniel Fuchs <[email protected]> wrote: > > Hi Lance, > > http://cr.openjdk.java.net/~lancea/8220252/webrev.00/src/java.naming/share/classes/javax/naming/ldap/LdapContext.java.frames.html > > It looks like > 78 * <h2>Context Request Controls</h2> > 100 * <h2>Connection Request Controls</h2> > 136 * <h2>Service Provider Requirements</h2> > > should be <h3> - it seems they are all logical subsections > of > 53 * <h2>Request Controls</h2>
Yes you are right, I missed that but it is updated at http://cr.openjdk.java.net/~lancea/8220252/webrev.01/index.html > > Otherwise looks good! Thank you and have a nice evening Best Lance > > best regards, > > -- daniel > > On 13/03/2019 18:55, Lance Andersen wrote: >> Hi all >> Please review the fix for 8220252, to address the javadoc header issues [1] >> in java.naming >> The webrev can be found at: >> http://cr.openjdk.java.net/~lancea/8220252/webrev.00/index.html >> Best >> Lance >> [1] https://mail.openjdk.java.net/pipermail/jdk-dev/2019-March/002671.html > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 [email protected] <mailto:[email protected]>
