Hi Joe,
I was aware that webrevs should be versioned, though I didn't see the
value for small change sets like this one.
You seem to think there is a value. Can you explain it to me?
Best Regards
Adam Farley
IBM Runtimes
Joe Darcy <joe.da...@oracle.com> wrote on 22/03/2019 15:40:15:
> From: Joe Darcy <joe.da...@oracle.com>
> To: Adam Farley8 <adam.far...@uk.ibm.com>, Mandy Chung
> <mandy.ch...@oracle.com>
> Cc: core-libs-dev <core-libs-dev@openjdk.java.net>
> Date: 22/03/2019 15:42
> Subject: Re: RFR: JDK-8216558: Lookup.unreflectSetter(Field) fails
> to throw IllegalAccessException for final fields
>
> A quick comment below...
>
> On 3/22/2019 4:33 AM, Adam Farley8 wrote:
> > Hi Mandy,
> >
> > Answers below. :)
> >
> > Mandy Chung <mandy.ch...@oracle.com> wrote on 22/03/2019 00:35:00:
> >
> >> From: Mandy Chung <mandy.ch...@oracle.com>
> >> To: Adam Farley8 <adam.far...@uk.ibm.com>
> >> Cc: core-libs-dev <core-libs-dev@openjdk.java.net>
> >> Date: 22/03/2019 00:35
> >> Subject: Re: RFR: JDK-8216558: Lookup.unreflectSetter(Field) fails
> >> to throw IllegalAccessException for final fields
> >>
> >> 217 //If this is a USA test, then only the fraction
> >> of the expected failures will occur; those which are both static and
> > final.
> >> 218 if (fl !=
> >> FieldLookup.MH_UNREFLECT_SETTER_ACCESSIBLE &&
> >> actualFieldNames.stream().anyMatch(s->!(s.contains("static")&&
> >> (s.contains("final")))))
> >>
> >> What is a USA test?
> > UNREFLECT_SETTER_ACCESSIBLE.
> >
> > I was trying to be brief, and I lost readability.
> >
> > Will re-upload with the expanded name.
>
> Please update distinct versions of a webrev (e.g. distinguished with .1,
> .2 directory names) rather than overwriting a single one. This make it
> easier for those coming to the review thread later to see the evolution
> of the changes over time.
>
> Cheers,
>
> -Joe
>
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
