Hello,
I agree it would be preferable to understand why the test times out
rather than just upping its timeout value.
Thanks,
-Joe
On 3/27/2019 4:23 PM, Mandy Chung wrote:
Hi Lance,
Do you understand what takes so long for this test to run?
Is it running fastdebug and -Xcomp or other flag?
Mandy
On 3/27/19 1:55 PM, Lance Andersen wrote:
Hi all ,
Please review this fix for
https://bugs.openjdk.java.net/browse/JDK-8216539 which increases the
timeout value for this test which fails once in a blue moon on windows.
———————
$ hg diff
diff -r dc66ada06693 test/jdk/tools/jar/modularJar/Basic.java
--- a/test/jdk/tools/jar/modularJar/Basic.java Tue Mar 26 15:36:19
2019 -0700
+++ b/test/jdk/tools/jar/modularJar/Basic.java Wed Mar 27 16:50:53
2019 -0400
@@ -54,7 +54,7 @@
* jdk.test.lib.util.FileUtils
* jdk.test.lib.JDKToolFinder
* @compile Basic.java
- * @run testng Basic
+ * @run testng/timeout=300 Basic
* @summary Tests for plain Modular jars & Multi-Release Modular jars
*/
——————————
Best
Lance
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[email protected] <mailto:[email protected]>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[email protected] <mailto:[email protected]>
