Hi Andrew,
This all looks good to me - thanks for making the changes.
Two nits:
- BE was barely acceptable when used like a local variable, but now I
think BIG_ENDIAN would be better.
- If you don't use static import you can name the UnsafeConstants fields
the obvious way without clashing with public fields in Unsafe.
Feel free to ignore those nits. If you do make a change no need to see
another webrev.
Thanks,
David
On 5/04/2019 1:19 am, Andrew Dinn wrote:
New webrev is now available. Re-reviews welcome.
JIRA: https://bugs.openjdk.java.net/browse/JDK-8221477
Webrev: http://cr.openjdk.java.net/~adinn/8221477/webrev.03
This version should address all comments from Thomas, David and Coleen.
Testing
Tier1 test passed.
Submit test passed.
regards,
Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
