Hi Daniel, Thanks. I should have spotted that slight mistake. That is what comes from just cutting and pasting. Have created a new webrev anyway: http://cr.openjdk.java.net/~sgroeger/8222027/webrev.02/ I presume I need someone else to review this and also get a sponsor (so they can actually make the change) as I am not a committer (YET!!!) Do you know anyone that can do this for me?
Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: [email protected] Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From: Daniel Fuchs <[email protected]> To: Steve Groeger <[email protected]> Cc: OpenJDK Core Libs Developers <[email protected]> Date: 05/04/2019 13:51 Subject: Re: RFR: TEST_BUG: 8222027 - java/util/logging/LogManager/TestLoggerNames.java generates intermittent ClassCastException Hi Steve, On 05/04/2019 13:14, Steve Groeger wrote: > Hi Daniel, > > Thanks for the quick review. > I too didnt see why the test wanted to obtain the TestLogger from the > LogManager, but I left it doing that just in case there was a reason. > If you think this is not needed then I agree with your suggested > modifications. I have created a new webrev here: > _https://urldefense.proofpoint.com/v2/url?u=http-3A__cr.openjdk.java.net_-7Esgroeger_8222027_webrev.01_-5F&d=DwID-g&c=jf_iaSHvJObTbx-siA1ZOg&r=78GW2OHz7nNTH2dBkTx7-TKh2QCt3JD3zukzeUO8RpA&m=Df0w0-wNA_rWl-TkWAFLlG6aQu1TT5WHca1Uzlnx8G0&s=Fcqc74kaTxOKtJS9P_kQ-qQak7U377oypPD77yt38gM&e= Perfect! Maybe remove the trailing " for" in throw new AssertionError("wrong logger returned for"); Sorry - that was my mistake... No need for a new webrev. Reviewed. best regards, -- daniel > Hopefully I understood what you were saying and these modification are > OK. Please can you re-review these and let me know if OK. > > Thanks > Steve Groeger > IBM Runtime Technologies > Hursley, Winchester > Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 > Fax (44) 1962 816800 > Lotus Notes: Steve Groeger/UK/IBM > Internet: [email protected] > > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU > > > > From: Daniel Fuchs <[email protected]> > To: Steve Groeger <[email protected]>, OpenJDK Core Libs Developers > <[email protected]> > Date: 05/04/2019 12:33 > Subject: Re: RFR: TEST_BUG: 8222027 - > java/util/logging/LogManager/TestLoggerNames.java generates intermittent > ClassCastException > ------------------------------------------------------------------------ > > > > Hi Steve, > > Good analysis! I believe we can make the fix even > more simpler by simply moving: > > TestLogger test = new TestLogger(..); > LogManager.getLogManager().addLogger(test); > > at the beginning of main. If we do that then we can get > rid of the new local variable 'tl' and of the > reachabilityFence() call. > > I see no real reason why the test wants to obtain > the TestLogger test from the LogManager. > > If you wanted to be extra cautious in preserving the original > test then you could also add: > > if (test != Logger.getLogger("com.foo.bar.zzz")) { > throw new AssertionError("wrong logger returned for"); > } > > in place of line 149... > > best regards, > > -- daniel > > On 05/04/2019 11:59, Steve Groeger wrote: > > Hi all, > > > > Please could I have a review for this bug: > > https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8222027&d=DwID-g&c=jf_iaSHvJObTbx-siA1ZOg&r=78GW2OHz7nNTH2dBkTx7-TKh2QCt3JD3zukzeUO8RpA&m=Df0w0-wNA_rWl-TkWAFLlG6aQu1TT5WHca1Uzlnx8G0&s=ZA3MXC7DrYMf7UBacMB-BeS9MVxWoZvSIrcuzPjhW8o&e= > > > > The webrev is here: > > https://urldefense.proofpoint.com/v2/url?u=http-3A__cr.openjdk.java.net_-7Esgroeger_8222027_webrev.00_&d=DwID-g&c=jf_iaSHvJObTbx-siA1ZOg&r=78GW2OHz7nNTH2dBkTx7-TKh2QCt3JD3zukzeUO8RpA&m=Df0w0-wNA_rWl-TkWAFLlG6aQu1TT5WHca1Uzlnx8G0&s=aQ7Xz4DUgXgJDrV6Y-ZE0AiDjJtOugZv1StE-2kuff4&e= > > > > Thanks > > Steve Groeger > > IBM Runtime Technologies > > Hursley, Winchester > > Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 > > Fax (44) 1962 816800 > > Lotus Notes: Steve Groeger/UK/IBM > > Internet: [email protected] > > > > Unless stated otherwise above: > > IBM United Kingdom Limited - Registered in England and Wales with number > > 741598. > > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire > PO6 3AU > > Unless stated otherwise above: > > IBM United Kingdom Limited - Registered in England and Wales with number > > 741598. > > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire > PO6 3AU > > > > > > > > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
