Hi Andrew, Thanks for working on this. Please find below few minor comments:-
1>. For "src/share/classes/java/util/JapaneseImperialCalendar.java" and "src/share/classes/sun/util/calendar/Era.java" please changes the date time format to be consistent with existing defined eras:- * 4 Heisei 1989-01-08 midnight local time - * 5 NewEra 2019-05-01 midnight local time + * 5 Reiwa 2019-05-01T00:00:00 local time Please change "2019-05-01T00:00:00 local time" to "2019-05-01 midnight local time" 2>. For "test/java/time/test/java/time/chrono/TestJapaneseChronology.java" please align "JapaneseEra.of(3)" with existing defined eras in "Object[][] eraNameData()". Regards, Deepak -----Original Message----- From: Andrew John Hughes <gnu.and...@redhat.com> Sent: Monday, April 8, 2019 10:10 AM To: jdk8u-...@openjdk.java.net; core-libs-dev@openjdk.java.net Subject: RFR: [8u] 8205432: Replace the placeholder Japanese era name Bug: https://bugs.openjdk.java.net/browse/JDK-8205432 Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8205432/webrev.01/ This is a relatively clean backport, with a few exceptions, mostly due to unneeded copyright changes or moved files: * 8u has FormatData_ja.java and JavaTimeSupplementary_ja.java in src/share/classes/sun/text/resources/ja/ rather than src/jdk.localedata/share/classes/sun/text/resources/ext/ * The XML files are in src/share/classes/sun/util/cldr/resources/21_0_1/common/main/ rather than src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ * 8u doesn't have test/jdk/java/util/Calendar/ZoneOffsets.java (JDK-8031145 & JDK-8165296 look like potential future test backports) * The changes in src/java.base/share/classes/sun/util/calendar/LocalGregorianCalendar.java take place in src/share/lib/calendars.properties in 8u I compared both with the 11u version of this patch and the 8u version of JDK-8202088, as well as searching the code base for 'NewEra'. Thanks, -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 https://keybase.io/gnu_andrew
