Thanks Patrick! Changes pushed.
David
On 16/04/2019 8:44 pm, Patrick Zhang OS wrote:
Done. http://cr.openjdk.java.net/~qpzhang/8222334/webrev.05
Regards
Patrick
-----Original Message-----
From: David Holmes <david.hol...@oracle.com>
Sent: Tuesday, April 16, 2019 6:34 PM
To: Patrick Zhang OS <patr...@os.amperecomputing.com>
Cc: core-libs-dev <core-libs-dev@openjdk.java.net>
Subject: Re: RFR: 8222334: java -Xss0 triggers StackOverflowError
Hi Patrick,
On 16/04/2019 7:42 pm, Patrick Zhang OS wrote:
Hi David,
Please see my updates, the two '0' size test cases. I have run them with jtreg
on jdk13 + linux + x86/aarch64 systems respectively, all passed.
http://cr.openjdk.java.net/~qpzhang/8222334/webrev.04
Thanks. Please update copyright years. Also instead of this comment:
It can verify the issue fixed in 8222334.
Just add 8222334 to the @bug line.
Thanks,
David
Regards
Patrick
-----Original Message-----
From: core-libs-dev <core-libs-dev-boun...@openjdk.java.net> On Behalf
Of Patrick Zhang OS
Sent: Tuesday, April 16, 2019 4:23 PM
To: David Holmes <david.hol...@oracle.com>
Cc: core-libs-dev <core-libs-dev@openjdk.java.net>
Subject: RE: RFR: 8222334: java -Xss0 triggers StackOverflowError
Sure I will add this, and fix the intention mentioned by Alan.
Regards
Patrick
-----Original Message-----
From: David Holmes <david.hol...@oracle.com>
Sent: Tuesday, April 16, 2019 4:17 PM
To: Patrick Zhang OS <patr...@os.amperecomputing.com>
Cc: Alan Bateman <alan.bate...@oracle.com>; core-libs-dev
<core-libs-dev@openjdk.java.net>
Subject: Re: RFR: 8222334: java -Xss0 triggers StackOverflowError
Patrick,
Sorry should have picked up on this earlier. Can you please update the
following two tests to add a test for '0' as appropriate:
./jdk/tools/launcher/TooSmallStackSize.java
./hotspot/jtreg/runtime/Thread/TooSmallStackSize.java
Thanks,
David
On 16/04/2019 5:47 pm, David Holmes wrote:
On 16/04/2019 5:40 pm, Alan Bateman wrote:
On 15/04/2019 08:48, David Holmes wrote:
On 15/04/2019 5:34 pm, Patrick Zhang OS wrote:
Removed it.
http://cr.openjdk.java.net/~qpzhang/8222334/webrev.03/jdk.changese
t
By the way, could you please sponsor to push it once approved?
thanks in advance.
Sure - if the core-libs person who also reviews doesn't volunteer
(hint hint ;-) )
This looks okay to me too, I think we should fix the intention in
ContinueInNewThread while we are there so it matches the rest of the
file.
Thanks Alan! I'll fix the indent before pushing.
David
-----
-Alan
