Hi Severin,

I took a look at this (again**) and although I'm not at all familiar with the actual cgroup facilities the changes seem reasonable in that they only look for a hierarchical memory limit if the initial limit is "unlimited".

So you can add me as a reviewer.

Thanks,
David

** I didn't previously review in the hope someone more cgroup knowledgeable would do so.

On 18/04/2019 3:32 am, Severin Gehwolf wrote:
Ping?

On Tue, 2019-04-09 at 11:33 +0200, Severin Gehwolf wrote:
Hi,

Could I get another reviewer for this, please? Bob Vandette already reviewed it.

Thank you!

Cheers,
Severin

On Tue, 2019-04-02 at 13:48 +0200, Severin Gehwolf wrote:
Could I get a second review, please?

Thanks,
Severin

On Thu, 2019-03-28 at 11:37 -0400, Bob Vandette wrote:
Sorry for the delay.  The update looks good.

Bob.


On Mar 25, 2019, at 1:30 PM, Severin Gehwolf <sgehw...@redhat.com> wrote:

On Fri, 2019-03-22 at 14:25 -0400, Bob Vandette wrote:
Could you maybe combine subsystem_file_contents with 
subsystem_file_line_contents
by adding an additional argument?

Done: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8217338/05/webrev/

Thanks,
Severin


Reply via email to