Hello,
We did review build changes as they were done in the sandbox, but IMO
this change needs a fresh review now since some things have changed in
the build since those reviews took place.
CompileJavaModules.gmk:
The -parameters flag to javac is currently only used for jdk.aot and
jdk.internal.vm.ci, where a comment is explaining why its needed in
those particular cases. Why is it needed for jdk.jpackage? We would like
to avoid snowflakes if possible.
Modules.gmk:
There is a new set of macros that should be used to check things like
target OS. The new macro is called like this:
ifeq ($(call isTargetOs, windows macosx linux), false)
Lib-jdk.jpackage.gmk and Launcher-jdk.jpackage.gmk:
Same thing with checking for target OS:
ifeq ($(call isTargetOs, windows), true)
Otherwise this looks good from a build perspective.
/Erik
On 2019-04-27 17:46, Philip Race wrote:
Adding build-dev for the build changes. I don't know if these were
previously reviewed there,
but I am not sure what the changes in NativeCompilation.gmk have to do
with jpackage.
-phil.
On 4/24/19, 5:47 PM, Andy Herrick wrote:
On 4/24/2019 8:44 PM, Andy Herrick wrote:
Please review changes for [1] which is the implementation bug for
JEP-343.
The webrev at [2] is the total cumulative webrev of changes for the
jpackage tool, currently in the JDK-8200758-branch branch of the
open sandbox repository.
The webrev at [3] shows the changes from EA-05 to EA-06.
sorry - the links are reversed from what is stated above. [2] is the
incremental webrev since EA 05, [3] is the cumulativewebrev
/Andy
The latest EA-6 (build 49) is posted at [4].
Please send feedback to core-libs-dev@openjdk.java.net
[1] https://bugs.openjdk.java.net/browse/JDK-8200758
[2] http://cr.openjdk.java.net/~herrick/8212780/webrev.05-06/
[3] http://cr.openjdk.java.net/~herrick/8212780/webrev.ea6/
[4] http://jdk.java.net/jpackage/
/Andy
