Hi Martin, Thanks for pushing this. :)
I'm not familiar with the jsr166 CVS system though, or the process of aiding a commit to it. Is there anything further I can do here? Best Regards Adam Farley IBM Runtimes David Holmes <[email protected]> wrote on 30/04/2019 08:51:24: > From: David Holmes <[email protected]> > To: Martin Buchholz <[email protected]>, core-libs-dev <core-libs- > [email protected]>, Doug Lea <[email protected]>, Chris Hegarty > <[email protected]>, Adam Farley8 <[email protected]>, > Jonathan Gibbons <[email protected]> > Date: 30/04/2019 08:52 > Subject: Re: RFR: jsr166 integration 2019-05 > > Hi Martin, > > On 30/04/2019 4:00 am, Martin Buchholz wrote: > > https://urldefense.proofpoint.com/v2/url? > u=https-3A__cr.openjdk.java.net_-7Emartin_webrevs_jdk_jsr166-2Dintegration_overview.html&d=DwICaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=P5m8KWUXJf- > CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=UyEQgUhk9l9hqIrxNx78GbVK6s9kwuLB__fHsbBQEM4&s=SK8eQrSdhQKsaQ2r_3pQeul3SMmsz6cVkfsxhnbVS_Q&e= > > > > 8222930: ConcurrentSkipListMap.clone() shares size variable between > > original and clone > > https://urldefense.proofpoint.com/v2/url? > u=https-3A__cr.openjdk.java.net_-7Emartin_webrevs_jdk_jsr166-2Dintegration_ConcurrentSkipListMap.clone_index.html&d=DwICaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=P5m8KWUXJf- > CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=UyEQgUhk9l9hqIrxNx78GbVK6s9kwuLB__fHsbBQEM4&s=Pk- > GWACLjrVblq0LJPSJn9LMoymdwz8L-UyVD4hcza4&e= > > https://urldefense.proofpoint.com/v2/url? > u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8222930&d=DwICaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=P5m8KWUXJf- > CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=UyEQgUhk9l9hqIrxNx78GbVK6s9kwuLB__fHsbBQEM4&s=OdJwEcMXYxKvHyJFfQ7JXlHTZe1NQbKybtHdwFTF8Qo&e= > > A real bug fix! > > Apologies to Adam for re-routing through jsr166 CVS. > > Adam, that loop is now written in Adam style. > > > > 8221120: CopyOnWriteArrayList.set should always have volatile write > > semantics > > https://urldefense.proofpoint.com/v2/url? > u=https-3A__cr.openjdk.java.net_-7Emartin_webrevs_jdk_jsr166-2Dintegration_CopyOnWriteArrayList.set_index.html&d=DwICaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=P5m8KWUXJf- > CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=UyEQgUhk9l9hqIrxNx78GbVK6s9kwuLB__fHsbBQEM4&s=QvLJqZYjuKPZqHfa3MTlnEvSYod575jkOWVQRnL6nQk&e= > > https://urldefense.proofpoint.com/v2/url? > u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8221120&d=DwICaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=P5m8KWUXJf- > CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=UyEQgUhk9l9hqIrxNx78GbVK6s9kwuLB__fHsbBQEM4&s=CPMrNrvCiJkQ1qQyvWoBET9DLP3M1h6NbOa33sMZZsA&e= > > > > 8221892: ThreadPoolExecutor: Thread.isAlive() is not equivalent to not > > being startable > > https://urldefense.proofpoint.com/v2/url? > u=https-3A__cr.openjdk.java.net_-7Emartin_webrevs_jdk_jsr166-2Dintegration_isAlive_index.html&d=DwICaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=P5m8KWUXJf- > CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=UyEQgUhk9l9hqIrxNx78GbVK6s9kwuLB__fHsbBQEM4&s=f2aPxCj5GYNPhtJ_fGMuXXyrE7aq2ExItMruyz4p0Ys&e= > > https://urldefense.proofpoint.com/v2/url? > u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8221892&d=DwICaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=P5m8KWUXJf- > CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=UyEQgUhk9l9hqIrxNx78GbVK6s9kwuLB__fHsbBQEM4&s=cnWwTGAK7- > FRM2vkHC0WJU0qWjSthz66uW2wLOKZnb0&e= > > That one looks good to me. > > Thanks, > David > ----- > > > 8220248: fix headings in java.util.concurrent > > https://urldefense.proofpoint.com/v2/url? > u=https-3A__cr.openjdk.java.net_-7Emartin_webrevs_jdk_jsr166-2Dintegration_h3_index.html&d=DwICaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=P5m8KWUXJf- > CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=UyEQgUhk9l9hqIrxNx78GbVK6s9kwuLB__fHsbBQEM4&s=oiB9FHta2Qn9vmBSQ9hE- > lPA44QB_mE1UYlogLwu_98&e= > > https://urldefense.proofpoint.com/v2/url? > u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8220248&d=DwICaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=P5m8KWUXJf- > CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=UyEQgUhk9l9hqIrxNx78GbVK6s9kwuLB__fHsbBQEM4&s=hRaFrU7cisY70PdMxnMTNy_NZuh_3fDQIoJKxq- > scog&e= > > > > 8203662: remove increment of modCount from ArrayList and Vector replaceAll() > > https://urldefense.proofpoint.com/v2/url? > u=https-3A__cr.openjdk.java.net_-7Emartin_webrevs_jdk_jsr166-2Dintegration_replaceAll_index.html&d=DwICaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=P5m8KWUXJf- > CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=UyEQgUhk9l9hqIrxNx78GbVK6s9kwuLB__fHsbBQEM4&s=UcfexeMYRSBugVy8Ds6v9U-6Gr9n4CmzXI12dFyg4S8&e= > > https://urldefense.proofpoint.com/v2/url? > u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8203662&d=DwICaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=P5m8KWUXJf- > CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=UyEQgUhk9l9hqIrxNx78GbVK6s9kwuLB__fHsbBQEM4&s=HMokVlOU1G5G46RDE- > d2oXvKBWHVE7YHGhbWhcPhwdU&e= > > This one remains in limbo. > > Some impartial openjdk steward should cast a tiebreaker vote or appoint > > someone impartial to cast a tiebreaker vote. > > > > 8219138: Miscellaneous changes imported from jsr166 CVS 2019-05 > > https://urldefense.proofpoint.com/v2/url? > u=https-3A__cr.openjdk.java.net_-7Emartin_webrevs_jdk_jsr166-2Dintegration_miscellaneous_index.html&d=DwICaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=P5m8KWUXJf- > CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=UyEQgUhk9l9hqIrxNx78GbVK6s9kwuLB__fHsbBQEM4&s=rtzk06a5EQ6yVVYKeZ7mWej5qmusPUM5nc8ivikv- > oA&e= > > > Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
