Thanks Lance!
--Joe
On 5/1/19, 2:23 PM, Lance Andersen wrote:
Hi Joe,
the change looks OK as does the test.
On May 1, 2019, at 12:46 PM, Joe Wang <huizhe.w...@oracle.com
<mailto:huizhe.w...@oracle.com>> wrote:
Please review a fix for a regression introduced during JDK 9
development. The issue was that a patch ported to the JDK added a
counter to count the number of values found in the XML document, and
then compared with the constraint's field count. The problem was that
the counter would get updated as the validator parsed through the XML
document. When the XML contains multiple elements, the counter
reflected the last one. If the last one didn't have the problem
field, then errors in previous elements wouldn't get reported. The
fix is to add a field to indicate whether the field exists in any of
the elements.
All tests and the new test that covers both cases in the original
patch and that reported in the JBS passed.
JBS: https://bugs.openjdk.java.net/browse/JDK-8220818
webrevs: http://cr.openjdk.java.net/~joehw/jdk13/8220818/webrev/
<http://cr.openjdk.java.net/%7Ejoehw/jdk13/8220818/webrev/>
Thanks,
Joe
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
