Ivan, There seem to be more places that use a somewhat similar pattern. I was wondering if you have seen them and decided not to include them in your patch for some reason (e.g. they really are quite different)?
Here are some of them: java.io.BufferedInputStream java.io.InputStream java.lang.AbstractStringBuilder java.nio.file.Files java.util.ArrayDeque java.util.Hashtable java.util.concurrent.ConcurrentHashMap java.util.concurrent.PriorityBlockingQueue java.util.regex.Pattern.quote There is also some number of occurrences in the jdk.* modules. > On 9 May 2019, at 02:50, Ivan Gerasimov <ivan.gerasi...@oracle.com> wrote: > > Hello! > > Jdk has several places with similar logic: an array needs to be reallocated > (by at least some defined amount), taking into account the maximum allowed > size of arrays. > > There's clearly an opportunity for refactoring, so it is proposed to > introduce a dedicated utility method for calculating the best new size of an > array. > > Would you please help review this enhancement? > > BUGURL: https://bugs.openjdk.java.net/browse/JDK-8223593 > WEBREV: http://cr.openjdk.java.net/~igerasim/8223593/00/webrev/ > > Mach5 job ran fine. > > Thanks in advance! > > -- > With kind regards, > Ivan Gerasimov >