Hi Andrew, looks good and trivial. Method could be static.
Cheers, Thomas On Thu, May 16, 2019 at 4:49 PM Andrew Dinn <ad...@redhat.com> wrote: > Please review this trivial change to MapperByteBuffer which encapsulates > the page align down operation in a suitably named method. > > JIRA: https://bugs.openjdk.java.net/browse/JDK-8224042 > webrev: http://cr.openjdk.java.net/~adinn/8224042/webrev.00/ > > Testing: > This was successfully exercised by running > > jdk/java/nio/channels/FileChannel/MapTest.java > > The test rounds down a sequence of sub-page offsets to successive pages > within a mapped buffer during testing of MappedByteBuffer method force(). > > regards, > > > Andrew Dinn > ----------- > Senior Principal Software Engineer > Red Hat UK Ltd > Registered in England and Wales under Company Registration No. 03798903 > Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander >
