Hi Joe,

Yes you are correct, thanks, I have updated the spec for the method plus added a couple of tests to make sure that the right exception is being thrown [1],

Thanks,
Vicente

[1] http://cr.openjdk.java.net/~vromero/8223726/webrev.01/

On 5/15/19 1:45 PM, Joe Darcy wrote:
Hi Vicente,

Should

 180      * @throws NullPointerException if any argument is {@code null}
 181      */
 182     static DirectMethodHandleDesc ofConstructor(ClassDesc owner,
 183                                                 ClassDesc... paramTypes) {

be "any argument or its contents is {@code null}", i.e. if the elements of paramTypes are null, is NPE thrown?

Otherwise, the change looks good.

Thanks,

-Joe

On 5/15/2019 8:36 AM, Vicente Romero wrote:
Please review fix for [1] at [2], this is a simple fix that is just rewording the doc of a couple of methods at java.lang.constant.MethodTypeDesc,

Thanks,
Vicente

[1] https://bugs.openjdk.java.net/browse/JDK-8223726
[2] http://cr.openjdk.java.net/~vromero/8223726/webrev.00/

Reply via email to