Looks good.
On 05/22/2019 03:18 AM, Deepak Kejriwal wrote:
Hi Roger,
Thanks for review. Please find below updated version of webrev:-
http://cr.openjdk.java.net/~dkejriwal/8214565_8214563/webrev.01/
Regards,
Deepak
-----Original Message-----
From: Roger Riggs
Sent: Friday, May 17, 2019 8:35 PM
To: core-libs-dev@openjdk.java.net
Subject: Re: [13] RFR: 8214565 and 8214563: Use {@systemProperty} for
definitions of system properties
Hi,
AsynchronousChannelProvider.java: line 144: needs a space in "anunspecified"
That sentence isn't very well worded, but is outside the scope of this
change to add the tag.
Otherwise, looks fine.
Roger
On 05/17/2019 06:49 AM, Alan Bateman wrote:
On 17/05/2019 10:49, Deepak Kejriwal wrote:
Hi all,
Please review the fix for following issues:-
https://bugs.openjdk.java.net/browse/JDK-8214565
https://bugs.openjdk.java.net/browse/JDK-8214563
Below is the webrev for above issues:
http://cr.openjdk.java.net/~dkejriwal/8214565_8214563/webrev.00/
This looks okay to me.
-Alan
