Thank you Brent for the review.

> On May 23, 2019, at 7:10 PM, Brent Christian <brent.christ...@oracle.com> 
> wrote:
> 
> Looks fine.  I guess you'll want to update/add the Copyright year in 
> JDKSecurityProperties.java.

Ah, forgot that, update below:

——————
$ hg diff test/lib/jdk/test/lib/security/JDKSecurityProperties.java
diff -r fb0cfce19262 test/lib/jdk/test/lib/security/JDKSecurityProperties.java
--- a/test/lib/jdk/test/lib/security/JDKSecurityProperties.java Thu May 23 
11:37:24 2019 -0700
+++ b/test/lib/jdk/test/lib/security/JDKSecurityProperties.java Thu May 23 
19:14:31 2019 -0400
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -29,7 +29,6 @@
 public final class JDKSecurityProperties {
 
     public static final List<String> jdkProps = List.of(
-        "com.sun.CORBA.ORBIorTypeCheckRegistryFilter",
         "crypto.policy",
         "jceks.key.serialFilter",
         "jdk.certpath.disabledAlgorithms",
------------------
> 
> -Brent
> 
> On 5/23/19 3:58 PM, Lance Andersen wrote:
>> Hi all,
>> Please review the fix for 8224682 which removes this legacy property left 
>> over from the removal from CORBA
>> The webrev can be found:  
>> http://cr.openjdk.java.net/~lancea/8224682/webrev.00/ 
>> <http://cr.openjdk.java.net/~lancea/8224682/webrev.00/>
>> Best
>> lance
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> 
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| 
>> Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering
>> 1 Network Drive
>> Burlington, MA 01803
>> lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> 
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>



Reply via email to