Look fine Brian; cheers,
-Joe
On 5/31/2019 8:33 AM, Brian Burkhalter wrote:
https://bugs.openjdk.java.net/browse/JDK-8225117
<https://bugs.openjdk.java.net/browse/JDK-8225117>
For SymmetricRangeTests the @ignore action tag needs to be after @library but
before @run.
For StringConstructorOverflow the test is OK as is, but move the @ignore to
just before @run for consistency.
Thanks,
Brian
--- a/test/jdk/java/math/BigInteger/StringConstructorOverflow.java
+++ b/test/jdk/java/math/BigInteger/StringConstructorOverflow.java
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2013, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -23,9 +23,9 @@
/*
* @test
- * @ignore This test has huge memory requirements
* @bug 8021204
* @summary Test constructor BigInteger(String val, int radix) on very long
string
+ * @ignore This test has huge memory requirements
* @run main/othervm -Xshare:off -Xmx8g StringConstructorOverflow
* @author Dmitry Nadezhin
*/
--- a/test/jdk/java/math/BigInteger/SymmetricRangeTests.java
+++ b/test/jdk/java/math/BigInteger/SymmetricRangeTests.java
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2013, 2017, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2013, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -23,8 +23,8 @@
/*
* @test
+ * @library /test/lib
* @ignore This test has huge memory requirements
- * @library /test/lib
* @run main/timeout=180/othervm -Xmx8g SymmetricRangeTests
* @bug 6910473 8021204 8021203 9005933 8074460 8078672
* @summary Test range of BigInteger values (use -Dseed=X to set PRNG seed)
