HI Stuart,, I added myself as a reviewer and the webrev looks fine.
Best Lance > On Jun 4, 2019, at 10:46 PM, Stuart Marks <stuart.ma...@oracle.com> wrote: > > Hi all, > > Please review this changeset and CSR request that remove the > traceInstructions() and traceMethodCalls() methods from java.lang.Runtime. > These methods have been deprecated for removal since Java 9, and they do > nothing. I've also removed a couple mentions of these methods from some tests. > > After this changeset, the only times these methods are mentioned is in > javac's symbol tables (for example, make/data/symbols/java.base-9.sym.txt) > where they are kept because they are present in earlier releases. > > They are also mentioned in the file > > test/hotspot/jtreg/runtime/appcds/ExtraSymbols.symbols.txt > > However, this file has a comment > >> 68 -1: # The values in this file are only used for testing the operation of >> 63 -1: # adding extra symbols into the CDS archive. None of the values >> 70 -1: # are interpreted in any way. So even if they contain names of classes >> 70 -1: # that have been renamed or removed, or string literals that have been >> 66 -1: # changed or remove from Java source code, it would not affect the >> 26 -1: # correctness of the test. > > so it seems that leaving mention of these methods in this file is harmless. > Based on this comment I've decided not to change this file. Nonetheless, I'm > including hotspot-dev in this review to make sure this is ok. (I seem to > recall a similar issue came up the last time I removed something.) > > Bug: > > https://bugs.openjdk.java.net/browse/JDK-8205131 > > Webrev: > > http://cr.openjdk.java.net/~smarks/reviews/8205131/webrev.0/ > > CSR request: > > https://bugs.openjdk.java.net/browse/JDK-8225330 > (if you review, please edit this issue and add yourself to the > Reviewed By field) > > Thanks, > > s'marks > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
