Hi Andrew, > On Jun 7, 2019, at 7:10 AM, Andrew Dinn <ad...@redhat.com> wrote: > >> I have uploaded a new webrev to fix the bove problems. This version also >> removes all the extra extraneous whitespace found by Brian and Gustavo. >> >> webrev: http://cr.openjdk.java.net/~adinn/8224974/webrev.07/ >> >> I have posted the changes to the submit repo to re-verify that all >> builds pass. I have also asked Jonathan Halliday to re-test this version >> against the Red Hat middleware clients to ensure there are no functional >> or performance changes. >> >> Modulo confirmation of those two checks this looks like it is a complete >> implementation. Unless anyone has more changes to recommend? > I just want to confirm that the submit job was clean and the middleware > clients are performing as expected.
I wanted to let you know that I ran version 7 above through our tests and did not see any problems related to your changes. I think the copyright years in PmemTest.java are wrong however: 2002, 2011. I suppose it should be just 2019. Thanks, Brian