On 6/20/2019 1:44 PM, Kevin Rushforth wrote:
Looks good. I presume you will update the HelpResources.properties for other languages before you push?

yes - they are updated - I just left them out of the file list.
/Andy
-- Kevin


On 6/20/2019 9:54 AM, Andy Herrick wrote:
On 6/19/2019 1:34 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].

This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage).

JDK-8225428: CLI change to remove "mode", rename to "package", and build only one target

[1] https://bugs.openjdk.java.net/browse/JDK-8225428

[2] http://cr.openjdk.java.net/~herrick/8225428/webrev.01/
/Andy

Minor revision [3] of help and message text in response to feedback:

[3] http://cr.openjdk.java.net/~herrick/8225428/webrev.02/

/Andy


Reply via email to