Thanks Lance!
Yes, JDK 14 it is, as Mark has asked us to retarget it to.
Best,
Joe
On 6/21/19, 1:23 PM, Lance Andersen wrote:
Hi Joe,
Overall looks OK. Its unfortunate to loose the formatting but given
it is not upstream, best to not have the additional work of going
through this exercise each time.
I have no additional changes to propose outside of what Daniel caught.
Even though there are a large number of files, the updates/impact
would be minimal if approved for JDFK 13. It might be easier though
to just target JDK 14 given where we are in the release cycle.
HTH
Lance
On Jun 20, 2019, at 6:45 PM, Joe Wang <huizhe.w...@oracle.com
<mailto:huizhe.w...@oracle.com>> wrote:
Please review an update to BCEL 6.3.1. This changeset will go into
JDK13 if approved, 14 if not.
1. Format
The changeset looks big, the majority of the changes however were
only different in format (i.e. Const.java). Unlike previous updates,
I'm leaving the format as they are in the upstream source so that
they won't show up in future updates. The only change I made were
those that had extremely long lines.
2. Exclusions
Since the BCEL component is for xml transform only, several
classes, that were not in the JDK, were excluded. Among them,
JavaWrapper.java for example can be problematic as it may use an
user-specified classloader to load arbitrary classes. It and related
classes were therefore excluded.
3. Warnings
Warnings were the main reason for the changes made to the original
source. It has been done in the previous update. For this update
therefore, I only had to re-apply them after making copies of the
upstream source. Still, I updated the LastModified field to indicate
a modification to the original source.
4. Deprecated fields to private
Deprecated fields in the original source were changed to private
ones in previous update. The changes are inherited in this update.
Again, the LastModified fields are also updated.
5. Test
Since the update does not affect the usage of the BCEL component,
it is essential to pass all of the existing tests. I've run the tests
multiple times and noted that all of the XML functional and unit
tests passed, so were JCK XML tests. I've also done a comparison
between builds before and after applying the BCEL update, and found
no change in performance.
JBS: https://bugs.openjdk.java.net/browse/JDK-8224157
webrevs: http://cr.openjdk.java.net/~joehw/jdk13/8224157/webrev/
<http://cr.openjdk.java.net/%7Ejoehw/jdk13/8224157/webrev/>
Thanks,
Joe
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
