Looks fine Brian > On Jul 16, 2019, at 3:45 PM, Brian Burkhalter <[email protected]> > wrote: > > I changed <code>…</code> to {@code …} and @exception to @throws in [3]. The > delta versus the original version [1] is at [2]. > > Thanks, > > Brian > > [1] http://cr.openjdk.java.net/~bpb/8073213/webrev.00/ > [2] http://cr.openjdk.java.net/~bpb/8073213/webrev.00-01/ > [3] http://cr.openjdk.java.net/~bpb/8073213/webrev.01/ > >> On Jul 16, 2019, at 10:19 AM, Lance Andersen <[email protected]> >> wrote: >> >> +1 >>> On Jul 16, 2019, at 12:08 PM, Brian Burkhalter <[email protected] >>> <mailto:[email protected]>> wrote: >>> >>> https://bugs.openjdk.java.net/browse/JDK-8073213 >>> <https://bugs.openjdk.java.net/browse/JDK-8073213> >>> <https://bugs.openjdk.java.net/browse/JDK-8073213 >>> <https://bugs.openjdk.java.net/browse/JDK-8073213>> >>> >>> Add javadoc of NPEs missing from two unread() methods; see below. >>> >>> It would not hurt in this class to also change <code>…</code> to {@code …} >>> and @exception to @throws but that would clutter up the review. >
<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 [email protected] <mailto:[email protected]>
