Hi Andy,

I think it is better not to use assert() in this case since it terminates app abnormally. Do we really should terminate execution if write() fails in this case? Can we ignore error? It might be better to handle it gracefully and then return from main() with error if we cannot ignore error.

Thanks,
Alexander

On 7/23/2019 2:07 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].

This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage).

[1] https://bugs.openjdk.java.net/browse/JDK-8228402

[2] http://cr.openjdk.java.net/~herrick/8228402/

/Andy


Reply via email to