Hello, seems we need another "CFRelease(cflocale)" in an early return case (see the default: ...) , new webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8228501.1/ Best regards, Matthias > -----Original Message----- > From: Baesken, Matthias > Sent: Mittwoch, 24. Juli 2019 08:48 > To: 'naoto.s...@oracle.com' <naoto.s...@oracle.com>; core-libs- > d...@openjdk.java.net > Subject: RE: RFR: 8228501: java_props_macosx.c - provide missing CFRelease > for CFLocaleCopyCurrent was: RE: java_props_macosx.c : > CFLocaleCopyCurrent() needs CFRelease ? > > Thanks for the review . > > Will push it tomorrow in case there are no objections . > > Could you (or someone 😉 ) comment on the other one too ? > > https://hg.openjdk.java.net/jdk/jdk/file/aaa83519e723/src/java.base/macos > x/native/libosxsecurity/KeystoreImpl.m#l522 > > > CFDataRef cfDataToImport = CFDataCreate(kCFAllocatorDefault, (UInt8 > *)rawData, dataSize); > .... > > err = SecKeychainItemImport(cfDataToImport, NULL, &dataFormat, NULL, > 0, ¶mBlock, defaultKeychain, > &createdItems); > > > Thanks, Matthias > > > > -----Original Message----- > > From: naoto.s...@oracle.com <naoto.s...@oracle.com> > > Sent: Dienstag, 23. Juli 2019 18:39 > > To: Baesken, Matthias <matthias.baes...@sap.com>; core-libs- > > d...@openjdk.java.net > > Subject: Re: RFR: 8228501: java_props_macosx.c - provide missing > CFRelease > > for CFLocaleCopyCurrent was: RE: java_props_macosx.c : > > CFLocaleCopyCurrent() needs CFRelease ? > > > > Thanks, Matthias. Changes look good to me. > > > > I think it is hard to provide a regression test for this change, then > > please add noreg-hard label to the issue. > > > > Naoto > > > > On 7/23/19 4:23 AM, Baesken, Matthias wrote: > > > Hello, please review the following fix that adds CFRelease to 2 > > CFLocaleCopyCurrent usages . > > > > > > Bug/webrev : > > > > > > https://bugs.openjdk.java.net/browse/JDK-8228501 > > > > > > http://cr.openjdk.java.net/~mbaesken/webrevs/8228501.0/ > > > > > > Best regards, Matthias > > > > > >