Thanks Martin . May I get a second review ? Best regards, Matthias
From: Doerr, Martin Sent: Mittwoch, 24. Juli 2019 12:14 To: Baesken, Matthias <matthias.baes...@sap.com>; 'hotspot-...@openjdk.java.net' <hotspot-...@openjdk.java.net>; core-libs-dev@openjdk.java.net; net-...@openjdk.java.net Cc: 'ppc-aix-port-...@openjdk.java.net' <ppc-aix-port-...@openjdk.java.net> Subject: RE: RFR: 8228482: fix xlc16/xlclang comparison of distinct pointer types and string literal conversion warnings Hi Matthias, I wouldn’t say „looks good”, but I think it’s the right thing to do 😊 The type casts look correct to fit to the AIX headers. libodm_aix: Good. Maybe we should open a new issue for freeing what’s returned by odm_set_path and we could also remove the AIX 5 support. NetworkInterface.c: Strange, but ok. Should be reviewed by somebody else in addition. Other files: No comments. Best regards, Martin From: ppc-aix-port-dev <ppc-aix-port-dev-boun...@openjdk.java.net<mailto:ppc-aix-port-dev-boun...@openjdk.java.net>> On Behalf Of Baesken, Matthias Sent: Dienstag, 23. Juli 2019 17:15 To: 'hotspot-...@openjdk.java.net' <hotspot-...@openjdk.java.net<mailto:hotspot-...@openjdk.java.net>>; core-libs-dev@openjdk.java.net<mailto:core-libs-dev@openjdk.java.net>; net-...@openjdk.java.net<mailto:net-...@openjdk.java.net> Cc: 'ppc-aix-port-...@openjdk.java.net' <ppc-aix-port-...@openjdk.java.net<mailto:ppc-aix-port-...@openjdk.java.net>> Subject: RFR: 8228482: fix xlc16/xlclang comparison of distinct pointer types and string literal conversion warnings Hello please review this patch . It fixes a couple of xlc16/xlclang warnings , especially comparison of distinct pointer types and string literal conversion warnings . When building with xlc16/xlclang, we still have a couple of warnings that have to be fixed : warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings] for example : /nightly/jdk/src/hotspot/os/aix/libodm_aix.cpp:81:18: warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings] odmWrapper odm("product", "/usr/lib/objrepos"); // could also use "lpp" ^ /nightly/jdk/src/hotspot/os/aix/libodm_aix.cpp:81:29: warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings] odmWrapper odm("product", "/usr/lib/objrepos"); // could also use "lpp" ^ warning: comparison of distinct pointer types, for example : /nightly/jdk/src/java.desktop/aix/native/libawt/porting_aix.c:50:14: warning: comparison of distinct pointer types ('void *' and 'char *') [-Wcompare-distinct-pointer-types] addr < (((char*)p->ldinfo_textorg) + p->ldinfo_textsize)) { ~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8228482 http://cr.openjdk.java.net/~mbaesken/webrevs/8228482.1/ Thanks, Matthias
