Hello, > On Aug 20, 2019, at 4:31 PM, Brian Burkhalter <brian.burkhal...@oracle.com> > wrote: > >> On Aug 20, 2019, at 2:45 PM, Ivan Gerasimov <ivan.gerasi...@oracle.com >> <mailto:ivan.gerasi...@oracle.com>> wrote: >> >> Would it make sense to add an argument `digits` to smallToString (like the >> same named argument of toString, the minimum number of digits to pad to), so >> it could zero-pad the result itself? >> >> This way we could avoid inserting zeros into the middle of a StringBuilder >> after a call to smallToString. > > Indeed I do not like the zero insertion either. I’ll investigate your idea.
I modified the patch so that characters are exclusively appended to the StringBuilder thereby eliminating copying of characters which are already present after the insertion point, viz., the padding with zeros after calling smallToString() in the recursive path. A delta versus version .01 is at [1] and the diff versus the tip at [2]. Thanks, Brian [1] http://cr.openjdk.java.net/~bpb/8229845/webrev.01-02/ [2] http://cr.openjdk.java.net/~bpb/8229845/webrev.02/
