Hi Pavel,
The changes in webrev.02 look good to me as well.
Thanks for renaming the constants in the test (I mean
TOLERANCE vs RIGHT_MARGIN and LEFT_MARGIN) - that makes
for a much better read.
best regards,
-- daniel
On 12/09/2019 13:26, Rob McKenna wrote:
Here's the updated version of the RFR based on the discussion so far:
http://cr.openjdk.java.net/~prappo/8151678/webrev.02/
For the reviewers. I totally forgot to explain why there's a multiplier of 2 in
some of the timeout calculations. The reason is the current behavior of
InitialDirContext. The supplied connect timeout seems to be used twice. Once
for making the actual TCP connection [1] and the second time while waiting for
the server to respond to the BIND message [2]. Thus, the total time spent in
that InitialDirContext ctor may be twice the expected. I believe it's a bug,
but the bug that is not related to the issue in question. The current issue
(8151678) is about intermittent failures of LdapTimeoutTest.
-Pavel
---------------------------------------------------
[1]http://hg.openjdk.java.net/jdk/jdk/file/79186d82463e/src/java.naming/share/classes/com/sun/jndi/ldap/Connection.java#l296,http://hg.openjdk.java.net/jdk/jdk/file/79186d82463e/src/java.naming/share/classes/com/sun/jndi/ldap/Connection.java#l320
[2]http://hg.openjdk.java.net/jdk/jdk/file/79186d82463e/src/java.naming/share/classes/com/sun/jndi/ldap/LdapClient.java#l154,http://hg.openjdk.java.net/jdk/jdk/file/79186d82463e/src/java.naming/share/classes/com/sun/jndi/ldap/LdapClient.java#l365
