Hi Joe,
I'm surprised there were so few changes.
Why are some of the Condition's marked // Conditionally serializable
and others // Not statically typed as Serializable
?
---
(I don't recall us ever testing serializability of Conditions)
---
ThreadPoolExecutor.Worker already has
/**
* This class will never be serialized, but we provide a
* serialVersionUID to suppress a javac warning.
*/
private static final long serialVersionUID = 6138294804551838833L;
Perhaps that should be replaced with a class-level suppression?
On Mon, Oct 14, 2019 at 5:33 PM Joe Darcy <[email protected]> wrote:
> Hello,
>
> Expanding the serialization review to include the java.util.concurrent
> package, please review the proposed changes:
>
> JDK-8232230: Suppress warnings on non-serializable non-transient
> instance fields in java.util.concurrent
> http://cr.openjdk.java.net/~darcy/8232230.0/
>
> Terminology added by JDK-8231913: "Discuss serializability of
> collections" used where appropriate.
>
> Thanks,
>
> -Joe
>
>
