On 10/22/19 3:37 PM, mark.reinh...@oracle.com wrote:
2019/10/22 14:12:18 -0700, mandy.ch...@oracle.com:
On 10/21/19 8:22 PM, mark.reinh...@oracle.com wrote:
RFE: https://bugs.openjdk.java.net/browse/JDK-8232080
CSR: https://bugs.openjdk.java.net/browse/JDK-8232753
Webrev: https://cr.openjdk.java.net/~mr/rev/8232080/
Looks good to me. One minor comment:
AddResourcePlugin isn't really a FILTER, probably best to add a new
category for new resource file. jlink hardcodes the order of the
categories that determines the order of the plugins to be executed (I
see the existing implementation could be cleaned up in the future). I
think we didn't want to the options resource to be filtered by
--exclude-resources plugin and so the add-options plugin should run
after all filter plugins.
Good point -- that makes sense.
Relative patch below; original webrev updated in place.
Looks good.
Mandy
