Thank you for the review, Lance. On 26/10/19 4:25 AM, Lance Andersen wrote: > > The change to Zip FS looks good. I re-worked the test so that it also > runs against ZipFile (which uses the CEN vs the LOC) and Zip FS in > addition to ZipInputStream for extra coverage. > > The webrev can be found > at: http://cr.openjdk.java.net/~lancea/8232879/webrev.00/index.html
Looks fine. A very minor note about http://cr.openjdk.java.net/~lancea/8232879/webrev.00/test/jdk/jdk/nio/zipfs/CRCWriteTest.java.html 136 while ((ze = zis.getNextEntry()) != null) { 137 assertNotNull(ze); Looks like an oversight - that assertNotNull(ze) on 137 isn't needed due to the != null check on 136. -Jaikiran
