Hi Lance, I looked at this patch as well and it seems good to me.
Cheers Christoph > -----Original Message----- > From: core-libs-dev <core-libs-dev-boun...@openjdk.java.net> On Behalf > Of Lance Andersen > Sent: Freitag, 25. Oktober 2019 20:42 > To: Alan Bateman <alan.bate...@oracle.com> > Cc: core-libs-dev <core-libs-dev@openjdk.java.net> > Subject: Re: RFR 8231451: ZipFileInputStream::skip handling of negative > values with STORED entries > > > > On Oct 23, 2019, at 4:58 PM, Alan Bateman <alan.bate...@oracle.com> > wrote: > > > > On 23/10/2019 19:06, Lance Andersen wrote: > >> > >>> On Oct 22, 2019, at 2:37 PM, Alan Bateman <alan.bate...@oracle.com > <mailto:alan.bate...@oracle.com>> wrote: > >>> > >>> I assume skip(Long.MAX_VALUE) will cause n+pos to overflow and it will > skip backwards rather than to the end. > >> > >> That is correct. If you prefer it to skip to the end, I will adjust > >> accordingly. > > It would be surprising to specify a positive value and have it skip > > backwards > so I think this should be fixed. > > I have updated the patch per your suggestion. > > The updated webrev can be found at: > http://cr.openjdk.java.net/~lancea/8231451/webrev.02/index.html > <http://cr.openjdk.java.net/~lancea/8231451/webrev.02/index.html> > > mach5 jdk-tier1 through jdk-tier3 are clean. > > Best > Lance > > > > -Alan > > <http://oracle.com/us/design/oracle-email-sig-198324.gif> > <http://oracle.com/us/design/oracle-email-sig-198324.gif> > <http://oracle.com/us/design/oracle-email-sig-198324.gif> > <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| > Principal Member of Technical Staff | +1.781.442.2037 > Oracle Java Engineering > 1 Network Drive > Burlington, MA 01803 > lance.ander...@oracle.com <mailto:lance.ander...@oracle.com> > >
