+1 You'll have to update the copyright years in the jni_util files.
Cheers Christoph > -----Original Message----- > From: David Holmes <david.hol...@oracle.com> > Sent: Mittwoch, 30. Oktober 2019 05:29 > To: Alexey Ivanov <alexey.iva...@oracle.com>; core-libs <core-libs- > d...@openjdk.java.net>; hotspot-runtime <hotspot-runtime- > d...@openjdk.java.net>; Langer, Christoph <christoph.lan...@sap.com> > Cc: Claes Redestad <claes.redes...@oracle.com> > Subject: Re: RFR JDK-8232724: Remove indirection with calling > JNU_NewStringPlatform > > LGTM. > > Thanks, > David > > On 30/10/2019 1:04 am, Alexey Ivanov wrote: > > Hi David, Christoph, > > > > Thank you for your reviews. > > > > On 29/10/2019 07:49, David Holmes wrote: > >>> Shall I remove one of them? The one in jvm.h because it's unused? > >> > >> Yes please remove the unused one in jvm.h. > > > > The updated webrev: > > http://cr.openjdk.java.net/~aivanov/8232724/webrev.01/ > > > > -- > > Regards, > > Alexey
