But this is also a very dangerous option because it may place time-bombs
into your packaged applications. For example, I recently realized that I
could
not make any https-requests any more in my packaged application. To fix
that I had to explicitly add "jdk.crypto.ec" to the list of modules for
jlink.
The symptoms of such bugs are not always very clear and do not
directly point you to missing modules with service providers.
So there should at least be a big warning that when you do not specify
the --bind-services option, you will have to watch out for sometimes
obscure runtime errors.
-- Michael
Message: 2
Date: Wed, 6 Nov 2019 05:18:15 +0100
From: Kevin Rushforth <kevin.rushfo...@oracle.com>
To: Philip Race <philip.r...@oracle.com>, Andy Herrick
<andy.herr...@oracle.com>
Cc: core-libs-dev <core-libs-dev@openjdk.java.net>
Subject: Re: RFR: JDK-8233594: create a new option --bind-servces to
pass on to jlink
Message-ID: <58a2d94b-6de5-baed-8427-fa6a5b821...@oracle.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Yes, this is a good change.
+1
-- Kevin
On 11/6/2019 2:02 AM, Philip Race wrote:
I noticed this problem when creating various demo scenarios so +1 to
the change, but
+\????????? Pass on --bind-seervices option to jlink (which will link
in \n\
typo here
-phil
On 11/5/19, 3:36 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This changes adds the --bind-services option and removes the previous
behavior of always including --bind-services in the jlink options
except when --add-modules was specified.
[1] - https://bugs.openjdk.java.net/browse/JDK-8233594
[2] - http://cr.openjdk.java.net/~herrick/8233594/
/Andy
