Hi Joe, Looks OK overall.
Best Lance > On Nov 20, 2019, at 4:48 PM, Joe Wang <huizhe.w...@oracle.com> wrote: > > Hi, > > Please review an update to Java CUP. This is an effort to move to the latest > version, v0.11b. JCUP is used by Xalan to generate XPathParser. Included in > the JDK are runtime classes and XPathParser. In CUP 0.11b, the main additions > to the runtime were SymbolFactory and ComplexSymbol that were used to report > a bit more details (locations) about the parsing process. They were not used > by Xalan nor the JDK since the benefit of these additions were in error > reporting, but Xalan and JDK used their own reporting mechanism. I could have > removed the JCUP error report process altogether, but decided to keep it in > case it might be used for debugging. > > The main change for this update therefore is to the XPathParser itself. Since > JCUP has been stable, and no major Xalan update in sight, I took the liberty > to re-format the whole class, plus some cleanup (mainly boxing/unboxing), > that constitute the changes before the inner class parser_actions. Within > parser_actions, the main change is that the 0.11b fixed the order of the > switch block. Other than that, I removed many unused variables, and also > formatted the long lines. > > There were no other material changes. So there's no new test, all existing > tests (including JCK) passed. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8233548 > webrevs: http://cr.openjdk.java.net/~joehw/jdk14/8233548/webrev/ > > Thanks, > Joe > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
