Hi Matthias, overall this looks good to me.
The only change to src/java.base/share/native/libjli/jli_util.c is the copyrights, so I guess this should be omitted... Cheers Christoph > -----Original Message----- > From: core-libs-dev <core-libs-dev-boun...@openjdk.java.net> On Behalf > Of Baesken, Matthias > Sent: Mittwoch, 27. November 2019 09:56 > To: core-libs-dev@openjdk.java.net > Subject: [CAUTION] RE: RFR: 8234821: remove unused functions from libjli > > Hello, I missed the reference from windows only code to JLI_MemRealloc , > new webrev : > > http://cr.openjdk.java.net/~mbaesken/webrevs/8234821.1/ > > Best regards, Matthias > > > > Hello, please review this small change . > It removed unneeded functions from libjli (shown by link-time-gc) . > > libjli contains a few functions that are shown as unused when applying link- > time-gc . > Those functions fall into 2 categories : > - totally unused/uncalled functions (can be deleted ) > - functions that are always inlined, but still kept separate when linking > (making them static often helps to remove the unneeded duplicate ) > > > ( Similar approach has been done to libnet , see : 8234629: remove unused > functions from libnet ) > > > > Thanks, Matthias > > > Bug/webrev : > > https://bugs.openjdk.java.net/browse/JDK-8234821 > > http://cr.openjdk.java.net/~mbaesken/webrevs/8234821.0/ >
