Hi Gerard, this looks good.
Cheers Christoph > -----Original Message----- > From: gerard ziemski <gerard.ziem...@oracle.com> > Sent: Samstag, 7. Dezember 2019 14:34 > To: hotspot-dev developers <hotspot-...@openjdk.java.net>; core-libs- > d...@openjdk.java.net; Claes Redestad <claes.redes...@oracle.com>; > Mandy Chung <mandy.ch...@oracle.com>; David Holmes > <david.hol...@oracle.com>; Sergey Bylokhov > <sergey.bylok...@oracle.com>; Langer, Christoph > <christoph.lan...@sap.com> > Subject: Re: RFR (M) 8223261 "JDK-8189208 followup - remove > JDK_GetVersionInfo0 and the supporting code" > > Hi all, > > Please review this revision 2 of a cleanup, where we remove > JDK_GetVersionInfo0 and related code, since we can get build versions > directly from within the VM itself. > > The rev2 differs from rev1 in that it's simpler due to JDK-8234185, > which was just checked in yesterday. Waiting for this fix to go in > first, allowed us not to have to delete the jdk_util.h file, which in > turn means that we don't have to touch all those files that used that > include. > > > bug: https://bugs.openjdk.java.net/browse/JDK-8223261 > webrev: http://cr.openjdk.java.net/~gziemski/8223261_rev2 > tests: passes Mach5 tier1,2,3 (another tier1,2,3,4,5,6 in progress...) > > > cheers
