I have filed JDK-8235667 to address that separately.  I agree the whole method should be replaced by a Files.copy operation, but because that is not related to the problem being addressed here, I went ahead and pushed that fix and filed this new issue.

/Andy

On 12/10/2019 1:31 AM, Alan Bateman wrote:
On 09/12/2019 23:17, Andy Herrick wrote:
Please review simple jpackage fir for issue [1] at [2]
transformFrom is not guaranteed to transfer all bytes so you can't ignore the return value. I assume you could replace move/all of this with a Files.copy that specifies REPLACE_EXISTING and COPY_ATTRIBUTES.

-Alan

Reply via email to