Looks ugly, but seems to be the only possible fix at the moment. Approved.
- Alexey
On 12/13/2019 1:01 AM, Alexander Matveev wrote:
Please review fix [2] for jpackage bug [1].
Not sure why it happens, but reading output from "hdiutil attach" was
not exiting immediately after process terminated with delays upto 20
seconds always and in some case upto 10 minutes and thus test was
timeout. Only possible workaround found is to wait for "hdiutil
attach" process to exit before reading output. In this case call to
"hdiutil attach" and reading output happens very fast and does not
hang for long time. Generating simple DMG image went from ~40 seconds
to ~20 seconds after fix. Test was done with verbose output enabled.
Thanks,
Alexander
[1] https://bugs.openjdk.java.net/browse/JDK-8235738
[2] http://cr.openjdk.java.net/~almatvee/8235738/webrev.00/
