On 27/01/2020 06:41, Nick Gasson wrote:
Hi David,

On 01/25/20 06:34 am, David Holmes wrote:
I've done this here:

http://cr.openjdk.java.net/~ngasson/8237521/webrev.02/

Need to check bytes >= 0 before aligning up so that allocateMemory(-1)
still throws an IllegalArgumentException.
That looks good to me.

Tested with jdk_foreign and runtime/Unsafe/.
Probably needs a bit more testing. IIRC the direct buffers use this API
so they would be a good test subject. Or perhaps Maurizio can run this
through our CI tier1-3 before pushing?

I tested again with jdk_core and hotspot_all_no_apps with no new
failures.

Would you or Maurizio mind sponsoring this for me if your testing is OK?

All Mach5 tier1,2,3 tests come up good (I've submitted a job two days ago).

Cheers
Maurizio



Thanks,
Nick

Reply via email to